Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Performant WP Query Check #193

Merged
merged 16 commits into from
Jun 21, 2023
Merged

Add Performant WP Query Check #193

merged 16 commits into from
Jun 21, 2023
+385 −38

Conversation

jjgrainger
Copy link
Contributor

Closes #27

@jjgrainger jjgrainger marked this pull request as ready for review June 15, 2023 15:47
felixarntz
felixarntz approved these changes Jun 15, 2023
View reviewed changes
Copy link
Member

@felixarntz felixarntz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jjgrainger LGTM! This just needs to have the merge conflict resolved, and related, the tiny comments below. Good to approve already though!

tests/phpunit/Checker/Checks/Performant_WP_Query_Params_Check_Tests.php Outdated Show resolved Hide resolved
tests/phpunit/Checker/Checks/Performant_WP_Query_Params_Check_Tests.php Outdated Show resolved Hide resolved
mukeshpanchal27
mukeshpanchal27 requested changes Jun 16, 2023
View reviewed changes
Copy link
Member

@mukeshpanchal27 mukeshpanchal27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes made for Composer have reintroduced the PHP 8.1 issue

composer.json Outdated Show resolved Hide resolved
@spacedmonkey spacedmonkey self-requested a review June 16, 2023 11:40
spacedmonkey
spacedmonkey reviewed Jun 20, 2023
View reviewed changes
composer.json Outdated Show resolved Hide resolved
@spacedmonkey
Copy link
Member

@jjgrainger @mukeshpanchal27 There seems to be a valid until test failure here.

Also, this should fix the issues with composer. #193 (comment)

mukeshpanchal27
mukeshpanchal27 approved these changes Jun 21, 2023
View reviewed changes
Copy link
Member

@mukeshpanchal27 mukeshpanchal27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jjgrainger and @spacedmonkey great work.

@mukeshpanchal27 mukeshpanchal27 merged commit 64f49be into trunk Jun 21, 2023
@mukeshpanchal27 mukeshpanchal27 deleted the feature/add-performant-wp-query-check branch June 21, 2023 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mukeshpanchal27 mukeshpanchal27 mukeshpanchal27 approved these changes

@felixarntz felixarntz felixarntz approved these changes

@spacedmonkey spacedmonkey spacedmonkey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create Performant_WP_Query_Params_Check
4 participants
@jjgrainger @spacedmonkey @felixarntz @mukeshpanchal27